New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always load default conf data before saved conf files #84

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
1 participant
@Quetzacoalt91
Member

Quetzacoalt91 commented Jun 21, 2018

This PR covers a case where the data saved in files may change between two release. It appeared upgrading a shop under 1.6 was impossible, because of download issues.

From now, even if the data does not exist in the saved content, it will be declared in the Configuration class.

Fixes http://forge.prestashop.com/browse/BOOM-4960

@Quetzacoalt91 Quetzacoalt91 added this to the 4.0.0 milestone Jun 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 0c440c3 into PrestaShop:dev Jun 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 22, 2018

Merging as it fixes an issue with the download step.

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:missing-conf-data branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment