New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop upgrade process if zip file can't be closed #85

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
1 participant
@Quetzacoalt91
Member

Quetzacoalt91 commented Jun 21, 2018

On huge servers with many files to backup but limited storage, "no space left" errors may occurs.

When it happened, the process did not stop and was still trying to add even more files to the zip file.
With this PR, we stop the process as we can't go further.

capture du 2018-06-21 12-21-52

ping @LouiseBonnard for string review.

@Quetzacoalt91 Quetzacoalt91 added this to the 4.0.0 milestone Jun 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 7469a0a into PrestaShop:dev Jun 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:zip-close branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment