Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last module tech improvements for v4 #22

Merged
merged 32 commits into from Sep 12, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 19, 2019

No description provided.

@Progi1984 Progi1984 changed the base branch from master to dev Jul 19, 2019
Progi1984 added 2 commits Jul 19, 2019
blockreassurance.php Outdated Show resolved Hide resolved
Progi1984 added 5 commits Jul 19, 2019
@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Jul 19, 2019
@Progi1984 Progi1984 referenced this pull request Jul 19, 2019
5 of 5 tasks complete
@Progi1984 Progi1984 requested a review from PierreRambaud Jul 19, 2019
Copy link
Contributor

left a comment

Veyr nice work ! A few minor issues, we're almost good 😄

blockreassurance.php Show resolved Hide resolved
blockreassurance.php Show resolved Hide resolved
blockreassurance.php Show resolved Hide resolved
tests/php/phpstan/bootstrap.php Show resolved Hide resolved
views/css/templates/index.php Show resolved Hide resolved
views/js/appearance/index.php Show resolved Hide resolved
views/js/index.php Show resolved Hide resolved
Progi1984 added 2 commits Jul 25, 2019
@Progi1984 Progi1984 requested a review from matks Jul 25, 2019
@matks
matks approved these changes Jul 25, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@Progi1984 Thanks ! Now we have to go through QA validation 😄

@matks matks changed the title Polish blockreassurance module Last module tech improvements for v4 Jul 25, 2019
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
views/js/front.js Outdated Show resolved Hide resolved
blockreassurance.php Outdated Show resolved Hide resolved
controllers/index.php Outdated Show resolved Hide resolved
Copy link
Member

left a comment

Oops I did mix up composer.json and package.json, sorry 😅

controllers/index.php Outdated Show resolved Hide resolved
@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@eternoendless I just pushed your asked modifications.

blockreassurance.php Outdated Show resolved Hide resolved
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 12, 2019
@PierreRambaud PierreRambaud merged commit 703a112 into PrestaShop:dev Sep 12, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Thanks @Progi1984

@Progi1984 Progi1984 deleted the Progi1984:issue14700 branch Sep 12, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Congratulations @Progi1984 and @pablopolyte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.