Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to remove a block #37

Merged
merged 4 commits into from Dec 4, 2019
Merged

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Nov 18, 2019

Questions Answers
Description? Added the ability to remove a block
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#15935
How to test? * Add a new block item
* Check the front it is not here
* Enable it
* Check the front it is here
* Edit it
* Check the front it is here
* Remove it
* Check the front it is not here
@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Nov 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 18, 2019

You removed 2700 lines 😄 is that intentional for this PR ?

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Nov 18, 2019

You removed 2700 lines smile is that intentional for this PR ?

Yes, Webpack compress to multiline into oneline now ;)

_dev/back/index.js Outdated Show resolved Hide resolved
_dev/back/index.js Outdated Show resolved Hide resolved
@Progi1984 Progi1984 force-pushed the Progi1984:issue15935 branch from 0d7fed3 to e1cc115 Nov 18, 2019
@Progi1984 Progi1984 requested a review from PierreRambaud Nov 18, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Dec 3, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 4, 2019

Thank you @Progi1984

@matks matks merged commit d89a627 into PrestaShop:dev Dec 4, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue15935 branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.