New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php qa report #21

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Copy link
Contributor

mickaelandrieu commented Jan 8, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #21 into master will increase coverage by 0.04%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
+ Coverage     97.59%   97.64%   +0.04%     
+ Complexity       75       74       -1     
============================================
  Files            14       14              
  Lines           208      212       +4     
============================================
+ Hits            203      207       +4     
  Misses            5        5
Impacted Files Coverage Δ Complexity Δ
src/Exceptions/InvalidPlace.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Exceptions/InvalidTransaction.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Clients/GuzzleClient.php 100% <ø> (ø) 3 <0> (ø) ⬇️
src/SimpleCircuitBreakerFactory.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Transactions/SimpleTransaction.php 97.29% <100%> (+0.15%) 13 <1> (ø) ⬇️
src/Utils/Assert.php 100% <100%> (ø) 11 <0> (ø) ⬇️
src/Utils/ErrorFormatter.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Storages/SymfonyCache.php 100% <100%> (ø) 7 <1> (ø) ⬇️
src/Storages/SimpleArray.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Places/AbstractPlace.php 100% <100%> (ø) 9 <1> (-1) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b91935...f8516ba. Read the comment docs.

@mickaelandrieu mickaelandrieu force-pushed the add-php-qa-report branch 3 times, most recently from 161f805 to f8516ba Jan 8, 2019

@@ -32,6 +32,7 @@ return PhpCsFixer\Config::create()
'self_accessor' => false,
'yoda_style' => null,
'non_printable_character' => true,
'phpdoc_no_empty_return' => false,

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jan 8, 2019

Author Contributor

This makes tools like psalm cry a river, sadly.

@mickaelandrieu mickaelandrieu merged commit ee5ebca into master Jan 8, 2019

@mickaelandrieu mickaelandrieu deleted the add-php-qa-report branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment