New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted the Client from SimpleCircuitBreaker #23

Merged
merged 5 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Copy link
Contributor

mickaelandrieu commented Jan 9, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #23 into master will increase coverage by 1.89%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
+ Coverage     97.64%   99.53%   +1.89%     
- Complexity       74       76       +2     
============================================
  Files            14       14              
  Lines           212      217       +5     
============================================
+ Hits            207      216       +9     
+ Misses            5        1       -4
Impacted Files Coverage Δ Complexity Δ
src/Transactions/SimpleTransaction.php 97.29% <ø> (ø) 13 <0> (ø) ⬇️
src/SimpleCircuitBreaker.php 100% <100%> (+6.89%) 16 <1> (ø) ⬇️
src/Clients/GuzzleClient.php 100% <100%> (ø) 4 <1> (+1) ⬆️
src/SimpleCircuitBreakerFactory.php 100% <100%> (ø) 2 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5ebca...a0137dd. Read the comment docs.

@mickaelandrieu mickaelandrieu force-pushed the extract-client branch 3 times, most recently from 9d03869 to efbf4d2 Jan 9, 2019

@mickaelandrieu mickaelandrieu force-pushed the extract-client branch 8 times, most recently from fde9f7d to a1d8388 Jan 9, 2019

@mickaelandrieu mickaelandrieu reopened this Jan 9, 2019

@mickaelandrieu mickaelandrieu force-pushed the extract-client branch from a1d8388 to 0871fad Jan 9, 2019

@mickaelandrieu mickaelandrieu force-pushed the extract-client branch from 78aedbf to e17a90f Jan 10, 2019

mickaelandrieu added some commits Jan 10, 2019

@mickaelandrieu mickaelandrieu merged commit 921d252 into master Jan 10, 2019

@mickaelandrieu mickaelandrieu deleted the extract-client branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment