New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the creation of places more robust #4

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Copy link
Contributor

mickaelandrieu commented Jan 4, 2019

No description provided.

mickaelandrieu added some commits Jan 4, 2019

@mickaelandrieu mickaelandrieu merged commit b317796 into master Jan 4, 2019

@mickaelandrieu mickaelandrieu deleted the solidify-place branch Jan 4, 2019

);
if ($hasStringValue) {
$errorMessage .= sprintf(' (%s)', (string) $value);

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 4, 2019

use implode ($errorMessage is an array) instead of concatening ugly spaces :P

$this->failures = $failures;
$this->timeout = $timeout;
$this->treshold = $treshold;
if ($this->validate($failures, $timeout, $treshold)) {

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 4, 2019

No need if statment when validate raise an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment