Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarty templates improvement #110

Merged
merged 3 commits into from Dec 2, 2019
Merged

Conversation

@micka-fdz
Copy link
Contributor

micka-fdz commented Nov 6, 2019

{block name='my_account_links'} is used twice :

  • templates/customer/page.tpl
  • templates/customer/_partials/my-account-links.tpl

In my opinion, the last one is useless and we can remove it.

micka-fdz added 3 commits Nov 6, 2019
Update my fork
@micka-fdz micka-fdz changed the title Remove duplicate of smarty block Smarty templates improvement Nov 6, 2019
@micka-fdz

This comment has been minimized.

Copy link
Contributor Author

micka-fdz commented Nov 6, 2019

Changes on main forms :

  • use same markup for all forms : <section class="form-fields">...</section>, <footer class="form-footer">...</footer>, etc.
  • use similar Smarty blocks : {block name='login_form_fields'}...{/block}, {block name='customer_form_fields'}...{/block}, etc.
  • remove duplicate of class attribute on buttons
  • better files indentation
@prestarocket prestarocket merged commit dfb6289 into PrestaShop:develop Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.