Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bs class and add utilities + make the button more ergonomic on phone #74

Merged
merged 49 commits into from Jul 15, 2019

Conversation

@Kmoulun
Copy link

commented Jul 5, 2019

Remove bs class and add utilities + make the button more ergonomic on phone

@prestarocket

This comment has been minimized.

step-number step-number

@PrestaShark

This comment has been minimized.

Copy link

commented on 3196303 Jul 8, 2019

My fault. class must to to img tag not a ;)

Kmoulun and others added some commits Jul 8, 2019

@@ -41,7 +41,7 @@
</div>

{block name='product_list_active_filters'}
<div id="" class="d-none d-md-block">
<div id="" class="d--none visible--desktop">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

just visible--desktop (no need d--none)

@@ -66,7 +66,7 @@
interactive = !$show_delivery_address_form and !$show_invoice_address_form
}
<div class="col-12 col-md-6 col-lg-4 mb-3">
<a href="{$new_address_delivery_url}" class="card bg-light h-100 text-center justify-content-center">
<a href="{$new_address_delivery_url}" class="delivery-address card bg-light">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

card--address instead of delivery-address

@@ -35,7 +35,7 @@
<article id="store-{$store.id}" class="store-item card shadow mb-3">
<div class="store-item-container card-body">
<div class="row">
<div class="col-md-3 col-lg-4 store-picture d-none d-md-block">
<div class="col-md-3 col-lg-4 store-picture d--none visible--desktop">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

no need d--none

@@ -23,7 +23,7 @@
* International Registered Trademark & Property of PrestaShop SA
*}
{block name='order_products_table'}
<div class="box d-none d-md-block">
<div class="box d--none visible--desktop">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

no need d--none

@@ -30,7 +30,7 @@

{block name='page_content'}
{if $cart_rules}
<table class="table table-striped d-none d-md-table">
<table class="table table-striped d--none d-md-table">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

just visible--desktop ?

@@ -32,14 +32,14 @@
<h6>{l s='Here are the orders you\'ve placed since your account was created.' d='Shop.Theme.Customeraccount'}</h6>

{if $orders}
<table class="table table-striped table-bordered d-none d-md-table">
<table class="table table-striped table-bordered d--none d-md-table">

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

just visible--desktop ?

<button class="form-control-submit btn btn-primary d-none d-sm-block" name="submit" type="submit">
<span class="d-none d-sm-inline">{l s='Send reset link' d='Shop.Theme.Actions'}</span>
<button class="form-control-submit btn btn-primary d--none d-sm-block" name="submit" type="submit">
<span class="d--none d-sm-inline">{l s='Send reset link' d='Shop.Theme.Actions'}</span>

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 10, 2019

Collaborator

visible--desktop & visible--mobile ?

<th class="d-none d-lg-table-cell">{l s='Payment' d='Shop.Theme.Checkout'}</th>
<th class="d-none d-lg-table-cell">{l s='Status' d='Shop.Theme.Checkout'}</th>
<th class="d--none d-lg-table-cell">{l s='Payment' d='Shop.Theme.Checkout'}</th>
<th class="d--none d-lg-table-cell">{l s='Status' d='Shop.Theme.Checkout'}</th>

This comment has been minimized.

Copy link
@prestarocket

prestarocket Jul 11, 2019

Collaborator

d--none d-lg-table-cell => visible--desktop ?

@prestarocket prestarocket merged commit c1980ef into PrestaShop:develop Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.