Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive for product quick view. #41

Conversation

MeKeyCool
Copy link

@MeKeyCool MeKeyCool commented Jun 30, 2022

Questions Answers
Branch? develop
Description? See #27511
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#27511.
Related PRs #28904
How to test? Cf. end of description.
Possible impacts? Some FO product list may have weird behavior under mobile.

Step to reproduce (considering all impacts)

As the product list can be seen in several ways, I'll list every place you can find a product list that may have been impacted by my fix.
All of coming step to reproduce bring you to one of this list and then you'll need to apply
PrestaShop/PrestaShop#27511 tests to check if expected behavior (PrestaShop/PrestaShop#27511 (comment)) is well implemented.

Expected behavior : For screen smaller than 576px (extra small, cf. bootstrap grid options),

  • the product image should not be deformed
  • the "quick view" should not displayed

    ☝️ Please be attentive to the grey line that @khouloudbelguith initially pointed out)

  • only one product should be displayed by row

Initial context

  • Fresh install of Prestashop 8.0.x
  • English language for FO and BO

Best sellers module

  • BO : Improve > Modules > Module manager > search "Top-sellers block" module and reset it.
  • FO : Go to home page then test "Best Sellers" product list block.

Category product list

  • FO : Go to a specific product view then test "other products in the same category" product list block.

Cross selling

  • FO : Proceed a command with more than 3 products (:warning: I encounter an issue at this stage but coming back to home page I could continue the test => #27375)
  • BO : Orders > Orders > find your command and update its status to "Payment accepted"
  • FO : Go to a product page from product you previsouly added to command. Then test "Customers who bought this product also bought:" product list block.

Featured products

  • FO : Go to home page and test "Popular Products" product list.

New products

  • FO : Go to home page then test "New products" product list block.

Special products

  • FO : Go to home page then test "On sale" product list block.

Viewed products

  • FO :
    1. Explore website products (you have to open specific product pages).
    2. Go to a product page and test "Viewed products" product list block.

Related products

  • BO : Sell > Catalog > Products > {select a product} > "Add a related product"; you need to add several related products. > Save
  • FO : Go to the selected product page and test "You might also like" product list block.

Brand products

  • FO : Go to home page, add brands to the url (for example on my local prestashop install, I have http://prestashop.com.local/en/brands), then select a brand and test "List of products by brand XXXXXX" product list block.

Product list by category

  • FO : Click a category in menu (example : "Accessories") and test product list block.

Search product

  • FO : Go to home page, search for generic product name (example : "mug") then test product list.

Supplier products

  • BO : shop parameters > general > display suppliers
  • FO : Go to home page, add supplier to the url (for example on my local prestashop install, I have http://prestashop.com.local/en/supplier), then select a supplier and test "List of products by supplier XXXXXX" product list block.

@NeOMakinG
Copy link

Starting to think that these classes could be default ones as a fallback (but well, not related to the PR so I'll just stamp)

@atomiix atomiix added the Waiting for QA Status: Waiting for QA feedback label Jul 5, 2022
@sLorenzini sLorenzini self-assigned this Jul 5, 2022
Copy link
Contributor

@sLorenzini sLorenzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @MeKeyCool,

Thank you for this PR.

Tested on develop and 8.0.x branches.

Quick view modal is well removed on mobile screen and grid is correctly displayed on all screen.

QA approved ✅

@sLorenzini sLorenzini added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Jul 7, 2022
@matks
Copy link
Contributor

matks commented Jul 8, 2022

Thank you @MeKeyCool

@matks matks merged commit 0c1ecfa into PrestaShop:develop Jul 8, 2022
@MeKeyCool MeKeyCool deleted the bugfix/27511_fix_responsive_for_quickview branch July 19, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: QA-Approved
Projects
None yet
5 participants