Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community reports #7

Merged
merged 16 commits into from Oct 21, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 17, 2019

  • Add a better logging system to retrieve requested urls and data
  • Use requests-cache to store http cache data
  • Use requests to continue to parse requests url in case there is a Link in the headers (When pagination is over 100)
  • Make PrestaShop/PrestaShop branches configurable in a config files
  • Write docstring as rtd style (https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html)
Copy link

Progi1984 left a comment

Need a second review

README.md Outdated Show resolved Hide resolved
core-weekly.py Outdated Show resolved Hide resolved
core_weekly/github.py Show resolved Hide resolved
core_weekly/github.py Outdated Show resolved Hide resolved
coreteam.py Show resolved Hide resolved
Copy link
Contributor

jolelievre left a comment

Some small changes left and it's ok for me

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
core-weekly.py Outdated Show resolved Hide resolved
core-weekly.py Show resolved Hide resolved
README.md Show resolved Hide resolved
@matthieu-rolland matthieu-rolland merged commit 481340c into PrestaShop:master Oct 21, 2019
@PierreRambaud PierreRambaud deleted the PierreRambaud:community/report branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.