Fix after Code Review PR#43

PrestaShopCorp · Jul 10, 2018 · ba92a06 · ba92a06
1 parent d8e6b3f
commit ba92a06
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/classes/CronJobsForms.php b/classes/CronJobsForms.php
@@ -282,7 +282,7 @@ public static function getTasksListValues()
         $table_name = _DB_PREFIX_.bqSQL(self::$module->name);
 
         $select_query = sprintf(
-            "SELECT * FROM `%s` WHERE `id_shop` = '%s' AND `id_shop_group` = '%s'",
+            "SELECT * FROM `%s` WHERE `id_shop` = '%d' AND `id_shop_group` = '%d'",
             $table_name,
             $id_shop,
             $id_shop_group

diff --git a/config.xml b/config.xml
@@ -2,7 +2,7 @@
 <module>
 	<name>cronjobs</name>
 	<displayName><![CDATA[Cron tasks manager]]></displayName>
-	<version><![CDATA[1.4.0]]></version>
+	<version><![CDATA[1.3.2]]></version>
 	<description><![CDATA[Manage all your automated web tasks from a single interface.]]></description>
 	<author><![CDATA[PrestaShop]]></author>
 	<tab><![CDATA[administration]]></tab>

diff --git a/upgrade/upgrade-1.0.6.php b/upgrade/upgrade-1.0.6.php
@@ -30,7 +30,8 @@
 
 function upgrade_module_1_0_6($module)
 {
-    $table_name = _DB_PREFIX_ . $module->name;
+    $table_name = _DB_PREFIX_.bqSQL($module->name);
+
 
     $look_for_columns = Db::getInstance()->ExecuteS(sprintf('SHOW COLUMNS FROM `%s` LIKE \'one_shot\'', $table_name));