Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to delete a cronjob if does'nt exist #45

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@camlafit
Copy link

camlafit commented Nov 30, 2018

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Jul 11, 2019

Hello @camlafit

Thank you for this PR. Can you provide me a module in order to test your PR ?

Thank you

@camlafit

This comment has been minimized.

Copy link
Author

camlafit commented Jul 22, 2019

Hello

As explained #44 any module can have this problem. To any reason an admin can remove hook from BO and broke cron related.

@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Oct 15, 2019

@sarahdib What is the reason to remove the Waiting for QA?

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Oct 15, 2019
@PierreRambaud PierreRambaud changed the base branch from master to dev Oct 15, 2019
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Oct 15, 2019

Hey, just notice your target the wrong branch. Can you rebase your branch please?

Copy link

PierreRambaud left a comment

Pull request needs to be rebased

@camlafit camlafit force-pushed the Webelys-PS:issue-44 branch from f6010fc to 132f44d Oct 21, 2019
@camlafit

This comment has been minimized.

Copy link
Author

camlafit commented Oct 21, 2019

Hello

code was rebased on dev

@PierreRambaud PierreRambaud merged commit 0748385 into PrestaShop:dev Oct 21, 2019
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Oct 21, 2019

Thanks @camlafit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.