New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply to validator.prestashop.com rules #18

Merged
merged 5 commits into from Aug 14, 2018

Conversation

Projects
None yet
4 participants
@matks
Contributor

matks commented Jun 18, 2018

This is a PR to comply with Modules validation standards (validator.prestashop.com).

Before the PR, there uses to be 4 errors, 18 warnings and 7 security issues.
The PR lowers these numbers to 16 warnings and 1 security issue.

I did not fix it all because the last errors/warnings do not seem relevant to me. This is mostly "line exceeds 120 characters" warnings that, if fixed, would decrease the code readability.

@marionf marionf assigned marionf and unassigned marionf Aug 14, 2018

@marionf marionf added QA approved and removed Waiting for QA labels Aug 14, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit a52bedd into PrestaShop:dev Aug 14, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 14, 2018

Thanks @matks

@eternoendless eternoendless added this to the 2.0.4 milestone Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment