Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exponential notation #5

Merged
merged 4 commits into from Jul 17, 2019

Conversation

@eternoendless
Copy link
Member

commented Jul 16, 2019

As noted by this PrestaShop issue, Number did not until now support exponential notation as described here: https://php.net/float

'.1e+2' => ['.1e+2', '', '10', '0', '10'],
'-.1e+2' => ['-.1e+2', '-', '10', '0', '-10'],
'+.1e+2' => ['+.1e+2', '', '10', '0', '10'],
'.01' => ['.01', '', '0', '01', '0.01'],

This comment has been minimized.

Copy link
@matks
@matks

matks approved these changes Jul 17, 2019

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Thanks @matks for the review

@eternoendless eternoendless merged commit 11e0f87 into PrestaShop:master Jul 17, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:extract-builder branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.