Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package default-mysql-server #27

Merged
merged 2 commits into from Sep 24, 2019

Conversation

@Quetzacoalt91
Copy link
Member

commented Sep 10, 2019

No description provided.

@PierreRambaud

This comment has been minimized.

Copy link

commented Sep 11, 2019

Weird, some tests are failing 🤔

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:default-mysql-server branch from 3e4b68b to 2d91188 Sep 12, 2019
@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

Failing tests are related to PrestaShop/PrestaShop#15324

@PierreRambaud

This comment has been minimized.

Copy link

commented Sep 19, 2019

Closed and reopened for travis, PrestaShop/PrestaShop#15324 has been merged!

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

Unfortunately we will have to wait for the day after for nightly, and the release of 1.7.6.2 for the 1.7 tag to pass

@matks

This comment has been minimized.

Copy link

commented Sep 23, 2019

Unfortunately we will have to wait for the day after for nightly, and the release of 1.7.6.2 for the 1.7 tag to pass

Is it because PrestaShop/PrestaShop#15324 is unfixed in 1.7.6.1 ?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

exactly

@matks

This comment has been minimized.

Copy link

commented Sep 23, 2019

It would be nice if we could build these docker images before releasing so we know we are not releasing a flawed version for docker.

But I guess this is what nightly tag is for 🤔

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

Indeed, we should have known about about that if Docker Hub notified us about the issue.

@PierreRambaud

This comment has been minimized.

Copy link

commented Sep 23, 2019

It would be nice if we could build these docker images before releasing so we know we are not releasing a flawed version for docker.

But I guess this is what nightly tag is for

But nightly is targeting the develop branch and not the 1.7.6.x :/

@matks

This comment has been minimized.

Copy link

commented Sep 23, 2019

It would be nice if we could build these docker images before releasing so we know we are not releasing a flawed version for docker.
But I guess this is what nightly tag is for

But nightly is targeting the develop branch and not the 1.7.6.x :/

Caramba !

I see 2 solutions:

  • add a hotfix on this repository to make 1.7.6.1 CLI-compatible, like Ready does

It's not pretty but it actually mirrors how this is done outside for shops in product: 1) fix the shop 2) submit the PR and wait for next release

  • declare this issue as critical and release a 1.7.6.2 ASAP

Maybe this last one is too much but I think that "the CLI must be runnable" is a feature important enough for us to add an Integration test that runs it, wdyt ?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

I'm in favor of not modifying this repository and wait for the release of 1.7.6.2. Otherwise we will add a fix we will forget to remove later.

@Quetzacoalt91 Quetzacoalt91 merged commit 660eb91 into PrestaShop:master Sep 24, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:default-mysql-server branch Sep 24, 2019
@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

I know that the build is failing, but as it is related to PS and not this repository, I'm merging anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.