New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style #177

Merged
merged 8 commits into from Dec 24, 2018

Conversation

Projects
None yet
3 participants
@eternoendless
Copy link
Member

eternoendless commented Dec 21, 2018

This PR includes several visual improvements. It's aimed at improving legibility (specially in large screens) by tweaking spacing and reducing visual clutter.

Read the commit log for more information.

Before:

devdocs prestashop com_1 7_themes_reference_javascript-events_

After:

localhost_1313_1 7_themes_reference_javascript-events_

eternoendless added some commits Dec 21, 2018

Tweak spacing
- Increased spacing between paragraphs and titles
- Content body is now limited to 1300px and centers itself horizontally on larger screens
Make code blocks stand out less for better readability
- Update highlight.js to 9.13.1
- Use code highlight style similar to github (dark text on light background)
- Tone down background on inline code

@mickaelandrieu mickaelandrieu merged commit 25b2d2c into PrestaShop:master Dec 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 24, 2018

Thanks @eternoendless => now let's all rest and enjoy great times with families and friends 😇😇

@eternoendless eternoendless deleted the eternoendless:improve-style branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment