New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document naming conventions #181

Merged
merged 2 commits into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@sarjon
Copy link
Member

sarjon commented Jan 5, 2019

Documents naming conventions discussed in PrestaShop/PrestaShop#10597.

It still needs proofreading and suggestions for improvements.

Todo:

  • Document services key naming
  • Grid naming
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 11, 2019

@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Jan 14, 2019

i've noticed one interesting thing, how do we structure templates with multiple partials (blocks)?

should we document this convention, that suggest to split partials (block) by page? @matks wdyt?

- Blocks
    - View # all the blocks for main view.html.twig page
        - personal_information.html.twig
        - addresses.html.twig
        - carts.html.twig
    - Index # all the blocks for main index.html.twig page
        - required_fields.html.twig
- view.html.twig # main page
- create.html.twig # main page
- index.html.twig # mian page

@mickaelandrieu mickaelandrieu merged commit 64dcf11 into PrestaShop:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 18, 2019

Thanks @sarjon, if something is missing here you can create a new pull request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment