New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a section for testing when they migrate a page #192

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Copy link
Contributor

mickaelandrieu commented Jan 22, 2019

No description provided.

@matks

matks approved these changes Jan 22, 2019

you have created.

You are required to add a smoke test (also called "survival") for every new page
you migrate.

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 22, 2019

Contributor
You are encouraged to add both unit and functional tests for every new class you have created.
But you must add a smoke test (also called "survival") for every new page you migrate.

Could be better to use must, wdyt?

<?php
namespace LegacyTests\Integration\PrestaShopBundle\Controller\Admin;
use LegacyTests\Integration\PrestaShopBundle\Test\WebTestCase;

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 22, 2019

Contributor

namespace and use are maybe useless, it can add confusion, because you only need to change the data provider.

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor Author

mickaelandrieu commented Jan 29, 2019

Thanks for review, comments addressed 👍

@mickaelandrieu mickaelandrieu merged commit 83de4e5 into PrestaShop:master Jan 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:added-smoke-tests branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment