Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation about value objects #256

Merged
merged 5 commits into from Oct 7, 2019

Conversation

@sarjon
Copy link
Contributor

sarjon commented Apr 17, 2019

No description provided.

@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Apr 17, 2019

@matks I've put it under Core development > Domain > Value Objects. However, there is Core development > CQRS, but I feel like Domain is more appropriate section for this docs.

Now I'm thinking where DTOs should be placed? Maybe CQRS section should be moved under Core development > Domain?

This structuring is crazy. 💥

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jul 5, 2019

There already is a Core Development > Architecture > Domain section, you can put it under that

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Aug 9, 2019

ping @sarjon, could you please rebase?

@sarjon sarjon force-pushed the sarjon:document-vo-and-dto branch from 43f5925 to 23aa1dc Aug 15, 2019
@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Aug 15, 2019

sarjon and others added 4 commits Aug 16, 2019
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 7, 2019

Thank you @sarjon

@matks matks merged commit 6a927ed into PrestaShop:master Oct 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sarjon sarjon deleted the sarjon:document-vo-and-dto branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.