New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add grid actions tutorial #270
Conversation
src/content/1.7/development/components/grid/tutorials/work-with-bulk-actions.md
Outdated
Show resolved
Hide resolved
I don’t use dash and underscore. So module name are weird 🤢but it’s work well. For example : https://github.com/Matt75/displayproductmanufacturer Long name... 🤮 By the way, I know only native module for 1.7 using underscore... On Addons I never seen module name with dash or underscore |
ping @PierreRambaud, everyone should be happy now! LGTM please 🙏 |
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
public function hookActionCustomerGridDefinitionModifier(array $params) | ||
{ | ||
// $params['definition'] is instance of \PrestaShop\PrestaShop\Core\Grid\Definition\GridDefinition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** @var \PrestaShop\PrestaShop\Core\Grid\Definition\GridDefinition */
$definition = $params['definition'];
$definition>getActions()->add(
use PrestaShop\PrestaShop\Core\Grid\Action\AbstractGridAction; | ||
|
||
/** It extends AbstractGridAction, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this
/** It extends AbstractGridAction,
* but you can also implement \PrestaShop\PrestaShop\Core\Grid\Action\GridActionInterface
*/ if for some reason you want to avoid using the abstract class
by
/**
* It extends AbstractGridAction,
* but you can also implement \PrestaShop\PrestaShop\Core\Grid\Action\GridActionInterface
* if for some reason you want to avoid using the abstract class
*/
…h-grid-actions.md Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
…h-grid-actions.md Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
Hello @PierreRambaud, I've applied your comments: LGTM? Cheers |
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
src/content/1.7/development/components/grid/tutorials/work-with-grid-actions.md
Outdated
Show resolved
Hide resolved
Hello @PierreRambaud, no problem it should be good now 👍 Cheers |
Thank you @mickaelandrieu |
No description provided.