Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add grid actions tutorial #270

Merged
merged 5 commits into from Sep 12, 2019

Conversation

@mickaelandrieu
Copy link
Member

commented May 17, 2019

No description provided.

@Matt75

This comment has been minimized.

Copy link

commented May 31, 2019

I don’t use dash and underscore. So module name are weird 🤢but it’s work well.

For example : https://github.com/Matt75/displayproductmanufacturer

Long name... 🤮
I hate underscore 😇

By the way, I know only native module for 1.7 using underscore... On Addons I never seen module name with dash or underscore

@mickaelandrieu

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

ping @PierreRambaud, everyone should be happy now!

LGTM please 🙏

public function hookActionCustomerGridDefinitionModifier(array $params)
{
// $params['definition'] is instance of \PrestaShop\PrestaShop\Core\Grid\Definition\GridDefinition

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jun 5, 2019

Contributor
/** @var \PrestaShop\PrestaShop\Core\Grid\Definition\GridDefinition */
$definition = $params['definition'];

$definition>getActions()->add(
use PrestaShop\PrestaShop\Core\Grid\Action\AbstractGridAction;
/** It extends AbstractGridAction,

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jun 5, 2019

Contributor

Replace this

/** It extends AbstractGridAction,
 * but you can also implement \PrestaShop\PrestaShop\Core\Grid\Action\GridActionInterface 
 */ if for some reason you want to avoid using the abstract class

by

/**
* It extends AbstractGridAction,
* but you can also implement \PrestaShop\PrestaShop\Core\Grid\Action\GridActionInterface 
* if for some reason you want to avoid using the abstract class
*/ 
mickaelandrieu and others added 2 commits Jun 12, 2019
…h-grid-actions.md

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
…h-grid-actions.md

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@mickaelandrieu

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Hello @PierreRambaud,

I've applied your comments: LGTM?

Cheers

@mickaelandrieu mickaelandrieu force-pushed the mickaelandrieu:how-to-grid-actions branch from c8146c1 to 01296d9 Aug 29, 2019
@mickaelandrieu

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

Hello @PierreRambaud,

no problem it should be good now 👍

Cheers

@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Thank you @mickaelandrieu

@matks matks merged commit dc78ce2 into PrestaShop:master Sep 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.