Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #293

Merged
merged 8 commits into from Jan 9, 2020
Merged

Conversation

@LocalHeroPro
Copy link
Contributor

LocalHeroPro commented Jun 22, 2019

No description provided.

Prestashop needs more recursive write permissions
@eternoendless eternoendless changed the title Update _index.md Update installation instructions Aug 8, 2019
src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Sep 12, 2019

@LocalHeroPro I included suggestions for you to apply 😉 it seems I cannot update your PR as you have not given us rights to do it

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 5, 2019

Please consider activating the option "Allow edits from maintainers" on your PR.

You can find it at the bottom of the right column:

image

Thanks!

LocalHeroPro and others added 3 commits Nov 5, 2019
Co-Authored-By: Mathieu Ferment <mathieu.ferment@prestashop.com>
Co-Authored-By: Mathieu Ferment <mathieu.ferment@prestashop.com>
Co-Authored-By: Mathieu Ferment <mathieu.ferment@prestashop.com>
@LocalHeroPro

This comment has been minimized.

Copy link
Contributor Author

LocalHeroPro commented Nov 5, 2019

@eternoendless as I can see, I have already checked that option.

@LocalHeroPro LocalHeroPro requested review from matks and eternoendless Nov 5, 2019
Copy link
Member

eternoendless left a comment

Some small changes and it's ok for me

src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
src/content/1.7/basics/installation/_index.md Outdated Show resolved Hide resolved
LocalHeroPro and others added 3 commits Dec 28, 2019
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
@matks matks dismissed their stale review Jan 9, 2020

Changes applied

@matks
matks approved these changes Jan 9, 2020
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 9, 2020

Thank you @LocalHeroPro

@matks matks merged commit d1a963d into PrestaShop:master Jan 9, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.