Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a table that sum up supported Symfony features #329

Merged
merged 4 commits into from Sep 9, 2019

Conversation

@mickaelandrieu
Copy link
Member

commented Aug 26, 2019

view


| Version | Symfony features |
|----------|------------------------------------------------------|
| 1.7.3 | Twig templates inheritance and Services declaration |

This comment has been minimized.

Copy link
@sarjon

sarjon Aug 26, 2019

Member

Are you sure service declaration is part of 1.7.3? 🤔 I think it's 1.7.5.

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 26, 2019

Author Member

wow ! you won't be certified if you don't know that @sarjon => PrestaShop/PrestaShop@4efccba

You can believe me on these subjects: this was my project :)

This comment has been minimized.

Copy link
@matks

matks Aug 26, 2019

Contributor

@sarjon is right to ask for confirmation 😉even if it was your project, you can make a mistake about it

This is why there are code reviews 😉

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 26, 2019

Author Member

it's the day where you guys try to challenge me 🤣 , you're hard I mean... it's only Monday 🤡

| Version | Symfony features |
|----------|------------------------------------------------------|
| 1.7.3 | Twig templates inheritance and Services declaration |
| 1.7.4 | Forms customization and Console commands declaration |

This comment has been minimized.

Copy link
@sarjon

sarjon Aug 26, 2019

Member

How Console commands declaration is different that Services declaration?

Forms customization is a bit confusing.

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 26, 2019

Author Member

before, if you declare the commands they weren't registered in the Console.

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Aug 26, 2019

Author Member

I've updated "Forms customization" to "Configuration forms"

@matks
matks approved these changes Sep 9, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Thank you @mickaelandrieu

@matks matks merged commit 6b7e706 into PrestaShop:master Sep 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.