Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for updatedProduct #381

Merged
merged 2 commits into from Jan 9, 2020
Merged

Conversation

@saturnxxi
Copy link
Contributor

saturnxxi commented Oct 10, 2019

updateProduct is fired before the combination update starts. updatedProduct after that

updateProduct is fired before the combination update starts. updatedProduct after that
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

Hi @saturnxxi thanks for the catch 😉

However if I'm not wrong, there is both updateProduct and updatedProduct events so we should not replace what is in the doc but add what is missing

@zalexki Can you confirm both updateProduct and updatedProduct events exist ?

@zalexki

This comment has been minimized.

Copy link
Contributor

zalexki commented Oct 11, 2019

Hey guys, hum i don't know much about this but i can see both events are registered and emitted in core.js and it's map file.

For the rest ¯_(ツ)_/¯

I guess it make sens but i didn't tested it, and yes let's document both of them.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

@Quetzacoalt91 help 😅

Can you confirm both updateProduct and updatedProduct events exist ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 11, 2019

@matks I confirm you that both exists.

themes/_core/js/product.js:285:      prestashop.emit('updateProduct', {
themes/_core/js/product.js:312:      prestashop.emit('updateProduct', {
themes/_core/js/product.js:325:  prestashop.on('updateProduct', (args) => {

and

themes/_core/js/product.js:197:        prestashop.emit('updatedProduct', data);
themes/_core/js/product.js:338:  prestashop.on('updatedProduct', (args) => {
themes/classic/_dev/js/product.js:34:  prestashop.on('updatedProduct', function (event) {
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

@matks I confirm you that both exists.

Thanks ! Then cannot accept his PR as it is

@eternoendless eternoendless changed the title Update _index.md Add documentation for updatedProduct Oct 31, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 9, 2020

I did the change. Thank you @saturnxxi

@matks matks dismissed their stale review Jan 9, 2020

Change applied

@matks matks merged commit db6a867 into PrestaShop:master Jan 9, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.