Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide module and context properties in ModuleFrontController #402

Merged

Conversation

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Nov 8, 2019

Fixes partially #398

@Quetzacoalt91 Quetzacoalt91 changed the title Provide module and context properties Provide module and context properties in ModuleFrontController Nov 8, 2019
@zalexki

This comment has been minimized.

Copy link
Contributor

zalexki commented Nov 8, 2019

you say '$this->context is a shortcut to the \Context class.' i think people will tend to not use it because it's just a shortcut maybe we can rephrase to incite people to use this instead of getContext.

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:controller-properties branch from 4dadf25 to fdd9cd9 Nov 8, 2019
@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

Quetzacoalt91 commented Nov 8, 2019

Indeed, Context::getContext has been specified

@zalexki

This comment has been minimized.

Copy link
Contributor

zalexki commented Nov 8, 2019

i meant saying something like $this->context is preferred to Context::getContext(). has it avoid calling getContext if it's already set and we want them to use $this->context over getContext() AFAIK

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:controller-properties branch from fdd9cd9 to e41f370 Nov 11, 2019
@Quetzacoalt91 Quetzacoalt91 merged commit 972e387 into PrestaShop:master Nov 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.