Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation rule about altering other modules #439

Conversation

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Jan 8, 2020

When validating a module, we have to make sure other modules content isn't altered.

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:module-checklist-forbid-altering-other-modules branch from a317b95 to 2d76baf Jan 8, 2020
@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:module-checklist-forbid-altering-other-modules branch from 2d76baf to abf642e Jan 8, 2020
@matks matks dismissed their stale review Jan 9, 2020

Found a typo

Co-Authored-By: Mathieu Ferment <mathieu.ferment@prestashop.com>
@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

Quetzacoalt91 commented Jan 10, 2020

Thanks for the suggested changes @matks

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 10, 2020

Thank you @Quetzacoalt91

@matks matks merged commit e59c8eb into PrestaShop:master Jan 10, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.