Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain db_data.sql #935

Merged
merged 2 commits into from Apr 19, 2021
Merged

Explain db_data.sql #935

merged 2 commits into from Apr 19, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Apr 15, 2021

Questions Answers
Description? Explain the behavior of file db_data.sql . Also rewrite a few items.
Fixed ticket?

@@ -44,7 +46,7 @@ file will be stored in the folder `/install/upgrade/sql/`.

Its name is the PS version on which the change will be applied.

For instance, here is the file *[1.7.3.0.sql](https://github.com/PrestaShop/PrestaShop/blob/1.7.3.x/install-dev/upgrade/sql/1.7.3.0.sql)*,
For instance, here is the file *[1.7.3.0.sql](https://github.com/PrestaShop/PrestaShop/blob/1.7.3.0/install-dev/upgrade/sql/1.7.3.0.sql)*,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is more likely to always be valid

Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback

Co-authored-by: Progi1984 <franck.lefevre@prestashop.com>
@matks matks merged commit a194684 into PrestaShop:master Apr 19, 2021
@matks
Copy link
Contributor Author

matks commented Apr 19, 2021

Thank you for review @Progi1984

@matks matks deleted the mention_db_data branch April 19, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants