New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized network calls #25

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 18, 2018

This contributions is not that huge!

The first commit puts all the badge images from gamification server into the module (and updates the path on badge image url).

The second commit optimizes and fix the function isFresh responsible of calling the server if files are outdated: as the function was broken, the CSS files from advices were requested everytime!

This doesn't solve the resiliency issue for now. I'm waiting for #24 to be merged as I want to write integration tests to confirm the module is totally functional even when gamification server is down.

WHERE `class_name` = "'.pSQL('ShopParameters').'"'
);
->getValue('SELECT MIN(id_tab)
FROM `'._DB_PREFIX_.'tab`

This comment has been minimized.

@PierreRambaud

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 18, 2018

Contributor

we could use PHP CS Fixer but ... oh wait! waiting for => #24

return false;
}
$lastFileUpdate = date("F d Y H:i:s.", filemtime($file) + $timeout);

This comment has been minimized.

@PierreRambaud

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 18, 2018

Contributor

we could use PHP CS Fixer but ... oh wait! waiting for => #24

@Quetzacoalt91 Quetzacoalt91 merged commit 52da937 into PrestaShop:dev Oct 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment