New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of 1.6.1.x releases #30

Merged
merged 2 commits into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 23, 2018

No description provided.

@eternoendless eternoendless changed the base branch from master to dev Oct 24, 2018

@marionf

This comment has been minimized.

marionf commented Oct 24, 2018

Every time I reinstall the module a new tab is created and I don't see any badge

capture d ecran_515

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 25, 2018

It should work now... but you need to reload the page and/or clear the cache.

ps1 6

I don't reproduce the multiple tab issue, what do I need to do?

@marionf

This comment has been minimized.

marionf commented Oct 25, 2018

I can't reproduce anymore the issue of duplicated tabs but I have a weird behavior with badges after Unintall/reinstall and reset the module. It seems badges are not really removed when the module is reseted or uninstalled.
My smarty cache is disabled and I am in private navigation but every time I reset the module old badges are back

https://drive.google.com/open?id=1Gbt-AjeeunKHkAEqyH1xY1CN6dB5Quur

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 25, 2018

Yes, it is expected (or not?): this data comes from the gamification server, when you uninstall the module the information about your badges are not deleted by the server.

So even if you install a new shop with your prestashop account, I'm pretty sure you will retrieve your "experience" in ecommerce.

Is it a new behavior compared to the current version of the gamification module?

@marionf

This comment has been minimized.

marionf commented Oct 25, 2018

I don't know what is the behavior excpected, nothing is specified about this module. It was already like this before your change, so no issue.
Just I find it strange comapred to the behavior of other modules for which the data are deleted when you reset/uninstall it
So, maybe we should think about it

@marionf marionf added QA approved and removed Waiting for QA labels Oct 25, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 25, 2018

So, maybe we should think about it

I agree, I was wondering about GDPR but it's not really personal information...

Thanks for review /c ping @Quetzacoalt91 would you mind to take a look and merge please?

@Quetzacoalt91 Quetzacoalt91 merged commit 9f1cb10 into PrestaShop:dev Oct 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:compat-1.6 branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment