Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deprecated create_function for PHP 7.2 #61

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@eternoendless
Copy link
Member

commented Feb 20, 2019

@marionf

This comment has been minimized.

Copy link

commented May 6, 2019

ping @sarahdib

@sarahdib

This comment has been minimized.

Copy link

commented May 7, 2019

@eternoendless

The module is not display properly :
Capture d’écran 2019-05-07 à 15 40 16
Capture d’écran 2019-05-07 à 15 40 37

Normally is like that :
Capture d’écran 2019-05-07 à 15 41 09

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

@sarahdib I don't think the display issue is related, I'll rebase the PR and let you check it out again.

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Jul 3, 2019

@PierreRambaud PierreRambaud merged commit 9bc79d9 into PrestaShop:dev Jul 3, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@eternoendless eternoendless deleted the eternoendless:fix branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.