Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Various improvements #64
This variable contained the list of all advices including premium and except addons. It was initialized in the hook event, then passed along to AdminGamificationController, who then used it as whitelist for filtering a list of advices of its own. This controller-generated list, before being filtered, will have either _only_ premium advices or all advices _except_ premium and addons. Following this, we can conclude that controller-generated list will always be a fully contained subset of the whitelist, therefore making the whitelist redundant and useless.
mickaelandrieu left a comment •
Looks good to me but can be improved removing the BC break (let's deprecate the old public function instead and rely on the new ones?)
Also, this need to be cs fixed :)