New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CS fixer #56

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
2 participants
@eternoendless
Member

eternoendless commented Oct 17, 2018

Cosmetic code changes

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented on gsitemap.php in 495c8f4 Oct 17, 2018

Do you want pre-increment here?

This comment has been minimized.

Member

eternoendless replied Oct 18, 2018

It's done automatically by CS fixer, both are fine in this context.

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented on 495c8f4 Oct 17, 2018

Looks much nicer. I think I have some issues with my CS fixer.

This comment has been minimized.

Member

eternoendless replied Oct 18, 2018

Tip: next time try launching cs-fixer using the --config option to make it use PrestaShop's rules

@eternoendless eternoendless merged commit 68af0cc into PrestaShop:dev Oct 18, 2018

@eternoendless eternoendless deleted the eternoendless:formatting branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment