New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy v4.1.0 of gsitemap #77

Merged
merged 19 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Dec 14, 2018

No description provided.

MathiasReker and others added some commits Oct 24, 2018

Merge pull request #61 from MathiasReker/Remove-root-category-from-si…
…temap

Remove the home category from the sitemap
Merge pull request #66 from MathiasReker/fix-index.php
Update index.php with full path
Merge pull request #73 from MathiasReker/fix-desc
Use meta description instead of description
Revert
Notice: Use of undefined constant _PS_CONFIG_DIR_ - assumed '_PS_CONFIG_DIR_' in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 30

Warning: include(_PS_CONFIG_DIR_/config.inc.php): failed to open stream: No such file or directory in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 30

Warning: include(): Failed opening '_PS_CONFIG_DIR_/config.inc.php' for inclusion (include_path='.;C:/laragon/etc/php/pear') in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 30

Notice: Use of undefined constant _PS_CONFIG_DIR_ - assumed '_PS_CONFIG_DIR_' in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 31

Warning: include(_PS_CONFIG_DIR_/../init.php): failed to open stream: No such file or directory in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 31

Warning: include(): Failed opening '_PS_CONFIG_DIR_/../init.php' for inclusion (include_path='.;C:/laragon/etc/php/pear') in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 31

Fatal error: Uncaught Error: Class 'Tools' not found in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php:34 Stack trace: #0 {main} thrown in C:\laragon\www\prestashop1.7.5\modules\gsitemap\gsitemap-cron.php on line 34
@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 14, 2018

No new features has been introduces, only bug fixes. Don't you think the version should be 4.0.1 instead?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 14, 2018

Some feature have been improved, and the number of modified files makes a new minor version more logical.

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 14, 2018

@Quetzacoalt91 I do understand now. Thank you :)

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 14, 2018

Do not merge today, as we do not want the new version to be deployed during the week end.

@Quetzacoalt91 Quetzacoalt91 merged commit 919911e into master Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment