Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme title #208

Merged
merged 1 commit into from Mar 17, 2022
Merged

Improve readme title #208

merged 1 commit into from Mar 17, 2022

Conversation

matks
Copy link
Contributor

@matks matks commented Mar 17, 2022

Questions Answers
Description? Improve readme
Type? improvement

@kpodemski
Copy link
Contributor

@matks, shouldn't the repo name be hummingbird-theme?

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Mar 17, 2022

@matks, shouldn't the repo name be hummingbird-theme?

If we do this, we are forced to git clone <repo-url> hummingbird because of the config.yml, and adding the word theme to a subfolder of themes looks wrong

@NeOMakinG NeOMakinG merged commit cfd2251 into PrestaShop:develop Mar 17, 2022
@NeOMakinG
Copy link
Contributor

@kpodemski if you want to talk about it, open an issue or slack!

@kpodemski
Copy link
Contributor

@NeOMakinG

it's exactly the same with the classic, this is why I thought we want to follow this naming convention 👍

not that important tbh

@NeOMakinG
Copy link
Contributor

@NeOMakinG

it's exactly the same with the classic, this is why I thought we want to follow this naming convention 👍

not that important tbh

Yeah and this is exactly why I said to @matks that classic repository shouldn't be named like this :(

@matks matks deleted the readme-2 branch March 17, 2022 10:32
@matks
Copy link
Contributor Author

matks commented Mar 17, 2022

Maybe we need to rename classic-theme to classic then 🤔

@NeOMakinG
Copy link
Contributor

Maybe we need to rename classic-theme to classic then 🤔

@eternoendless wdyt? Do we have some constraint about this?

@eternoendless
Copy link
Member

I named classic-theme that way because "classic" is a generic word and I thought it could be confusing otherwise. I'm not sure if we can rename the source of a composer package in packagist. Perhaps we can.

The package is still named prestashop/classic because the package name determines the installation directory and that unfortunately cannot be changed. Plus, the translation system does not support dashes in the module/theme name either.

The git clone issue is just a small inconvenience in my opinion, anyway the normal way to include a theme should be through composer (unless you're planning on working on the theme itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants