Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean helpers, add programmable media queries #325

Merged
merged 8 commits into from Jun 22, 2022

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Jun 21, 2022

Questions Answers
Description? Removes some obsolete classes, makes media queries programmable to match changes in variables and limit the size of the output
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Please indicate how to best verify that this PR is correct.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

If you need additional helper classes for each breakpoint, don't create another media query. Just add your class to the loop.

Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work dude!!!

@SharakPL SharakPL changed the title Clean helpers, add programable media queries Clean helpers, add programmable media queries Jun 22, 2022
@NeOMakinG NeOMakinG merged commit cd306d1 into PrestaShop:develop Jun 22, 2022
@NeOMakinG
Copy link
Contributor

Thanks @SharakPL

@SharakPL SharakPL deleted the clean-helpers branch June 22, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants