New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Cs fixes #36

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@PierreRambaud

PierreRambaud commented Sep 3, 2018

No description provided.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from master to dev Sep 3, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 3, 2018

Member

@PierreRambaud, note you must open your PRs for the dev branch on module repositories.

Member

Quetzacoalt91 commented Sep 3, 2018

@PierreRambaud, note you must open your PRs for the dev branch on module repositories.

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 3, 2018

@Quetzacoalt91 Yes sorry, some repositories still have master branch :( We maybe need to change it on all repositories?

PierreRambaud commented Sep 3, 2018

@Quetzacoalt91 Yes sorry, some repositories still have master branch :( We maybe need to change it on all repositories?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 3, 2018

Member

All modules use the master branch as production ready. :)

Member

Quetzacoalt91 commented Sep 3, 2018

All modules use the master branch as production ready. :)

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 3, 2018

Thanks for information :D

PierreRambaud commented Sep 3, 2018

Thanks for information :D

@Quetzacoalt91 Quetzacoalt91 merged commit 592ae68 into PrestaShop:dev Sep 6, 2018

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/errors branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment