Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing domains #12

Merged
merged 5 commits into from Dec 4, 2019
Merged

Add missing domains #12

merged 5 commits into from Dec 4, 2019

Conversation

@LouiseBonnard
Copy link

LouiseBonnard commented Oct 21, 2019

No description provided.

prestafraud.php Outdated Show resolved Hide resolved
prestafraud.php Outdated Show resolved Hide resolved
prestafraud.php Outdated Show resolved Hide resolved
prestafraud.php Outdated Show resolved Hide resolved
prestafraud.php Show resolved Hide resolved
@matks

This comment has been minimized.

Copy link

matks commented Oct 23, 2019

@LouiseBonnard this module has not been modified since 2017, and before 2015 🤔 and it does not look like a native module

Do you know if it's still used ? Maybe we should just drop it ?

@LouiseBonnard

This comment has been minimized.

Copy link
Author

LouiseBonnard commented Oct 23, 2019

@matks, it is still available in the back office (in Modules > Modules Catalog), it is called PrestaShop Security. ;-)

@matks

This comment has been minimized.

Copy link

matks commented Oct 23, 2019

It's not because it's available that it's maintained. I think any software that has not been modified for 4 years can be considered obsolete.

@LouiseBonnard

This comment has been minimized.

Copy link
Author

LouiseBonnard commented Oct 23, 2019

So we're good!

@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Nov 21, 2019

@LouiseBonnard You need to update the code with your suggestions maybe? 😉

@LouiseBonnard

This comment has been minimized.

Copy link
Author

LouiseBonnard commented Nov 22, 2019

I'd like someone else's feedback before, there are wordings that seem outdated to me... @sarahdib perhaps?

@colinegin

This comment has been minimized.

Copy link

colinegin commented Dec 4, 2019

This PR can be merged !

@PierreRambaud PierreRambaud merged commit 6983de2 into dev Dec 4, 2019
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Dec 4, 2019

@PierreRambaud PierreRambaud deleted the LouiseBonnard-patch-1 branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.