Avoid infinite loop when we can't find a matching relation with conditions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosomb
reviewed
Oct 31, 2022
nicosomb
approved these changes
Oct 31, 2022
matks
approved these changes
Nov 15, 2022
|
I added some more infos as this PR context is complex |
Progi1984
approved these changes
Nov 18, 2022
|
Tested. The fix fixes the bug in the issue context and doesn't change the initial behavior. |
|
Thanks @mflasquin and @Progi1984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the example provided in #12 the guest entity is blocked because we try to generate guest information and we need a customer guest for that.
However in the config.yml file, we have set we need only 1 customer. In the definition of the customer entity, the customer can be a guest only with 10% chance. So if you're lucky, you have a customer and it works, if you're not lucky... it fails. This PR does not solve completely the problem but introduce mitigation steps that should allow avoiding the problem in most cases by performing retries.