Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created specs for FO produc lists - flags links #75

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@samuel-pires
Copy link
Contributor

samuel-pires commented Oct 17, 2019

I detailed the behavior of the product thumbnails' links after rework in #15930, nothing new but the spec was missing.

Version

1.7.6.2

What

In product lists, on product thumbnail, the flags are not linked.

Why

We decided not to link the flags because at least to possibilities exist:

  • Link them to the product page, as in 1.6
  • Link them to the list of all products sharing the parameter/characteristic in the flag (ex: -20%, New, etc.)

Without further research, we decided to let the behavior as it used to be in the previous 1.7 versions.
The developments made allow to easily add a link to the flag.

@samuel-pires samuel-pires merged commit 254dbe0 into master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.