Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing all stylelint errors #73

Merged
merged 13 commits into from Dec 11, 2019
Merged

Conversation

@NeOMakinG
Copy link

NeOMakinG commented Dec 4, 2019

#72 needs to be merged first!

QA : Compare index.html on develop branch with this branch's index.html, if there are a lot of differences then tell me (it should probably not be different visually, it's just linting)

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Dec 4, 2019
package.json Outdated Show resolved Hide resolved
@PierreRambaud PierreRambaud force-pushed the NeOMakinG:stylelint-errors branch from 248fc90 to 8c0dd3b Dec 4, 2019
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Dec 5, 2019

One more review and merge @Progi1984 maybe?

scss/_breadcrumb.scss Show resolved Hide resolved
scss/_custom-forms.scss Show resolved Hide resolved
scss/_buttons.scss Show resolved Hide resolved
scss/_material-checkbox.scss Show resolved Hide resolved
scss/_material-checkbox.scss Show resolved Hide resolved
scss/_tables.scss Show resolved Hide resolved
scss/_tables.scss Show resolved Hide resolved
scss/_type.scss Show resolved Hide resolved
scss/_type.scss Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Dec 5, 2019

@jolelievre Having html tag like a or i or tr is pretty useless when you already target a class.

Copy link

jolelievre left a comment

Just the comment to move please and I approve as well

scss/_alerts.scss Show resolved Hide resolved
scss/_breadcrumb.scss Show resolved Hide resolved
scss/_buttons.scss Show resolved Hide resolved
scss/_custom-forms.scss Show resolved Hide resolved
scss/_material-checkbox.scss Show resolved Hide resolved
&:checked {
+ i.md-checkbox-control:before {
}
/*! @noflip */ // for RTL compatibility

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 5, 2019

Only this comment to move please, it doesn't make sense to leave it here but it's still useful

scss/_variables.scss Show resolved Hide resolved
@NeOMakinG

This comment has been minimized.

Copy link
Author

NeOMakinG commented Dec 11, 2019

Sarah told me to pass it to QA Approved because she doesn't have rights to change it

@PierreRambaud PierreRambaud merged commit 31b5356 into PrestaShop:develop Dec 11, 2019
@PierreRambaud

This comment has been minimized.

Copy link

PierreRambaud commented Dec 11, 2019

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.