Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toast modifier to alert component #75

Merged
merged 4 commits into from Jan 8, 2020

Conversation

@NeOMakinG
Copy link

NeOMakinG commented Dec 6, 2019

Related with PrestaShop/PrestaShop#16595

This PR also contains PrestaShop/PrestaShop#16606 and PrestaShop/PrestaShop#16607 modifications

Job is done but #73 needs to be merged before so we can lint

How to test : build assets and compare index.html alerts with invision screens on related PRs

@NeOMakinG NeOMakinG marked this pull request as ready for review Dec 16, 2019
@NeOMakinG NeOMakinG changed the title [WIP] Adding toast modifier to alert component Adding toast modifier to alert component Dec 16, 2019
@sarahdib sarahdib added QA approved and removed Waiting for QA labels Dec 19, 2019
@sarahdib sarahdib self-assigned this Dec 19, 2019
@eternoendless eternoendless changed the title Adding toast modifier to alert component Add toast modifier to alert component Jan 7, 2020
index.html Show resolved Hide resolved
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jan 8, 2020

Thank you @NeOMakinG

@eternoendless eternoendless merged commit fe37f4f into PrestaShop:develop Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.