Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help-box and improve popover component #83

Merged
merged 3 commits into from Jan 8, 2020

Conversation

@NeOMakinG
Copy link

NeOMakinG commented Dec 16, 2019

Related to PrestaShop/PrestaShop#16603

How to test : Build assets (npm run build or npm run watch) and then compare with issue's specs on the index.html of the UI Kit, if there are var missing, it's because past PR's needs to be merged before..

Help box is at bottom at the page

@NeOMakinG NeOMakinG changed the title Adding help-box and improving popover component [WIP] Adding help-box and improving popover component Dec 16, 2019
@NeOMakinG NeOMakinG changed the title [WIP] Adding help-box and improving popover component Adding help-box and improving popover component Dec 16, 2019
@sarahdib sarahdib added QA approved and removed Waiting for QA labels Dec 18, 2019
@eternoendless eternoendless changed the title Adding help-box and improving popover component Add help-box and improve popover component Jan 8, 2020
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jan 8, 2020

Thank you @NeOMakinG

@eternoendless eternoendless merged commit 10044d8 into PrestaShop:develop Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.