Skip to content
Permalink
Browse files

Refactoring and regex pattern change (#71)

* Fix Regex when it fail because of one space somewhere

More, \r\n is a Windows eol when Linux use \n only and Mac \r.
Use standard \s for [ \t\r\n\f].

* Better usage of regex and add tests plus move to phpunit 6+

* Change file name foçr test with spaces

* Prevent Error:         Incorrect whitelist config,

* Add tests + wrong signature

Tests must be assertSame(Expected, Actual value)

* Cs Fixer

* Cs fixer on test directory

* Update dependencies due to security check
  • Loading branch information
PierreRambaud authored and mickaelandrieu committed Jul 3, 2018
1 parent 3b9ae5d commit 44f28c8966aca556156d822f8a15d78c33bd5c0b
@@ -1,4 +1,5 @@
/app/config/parameters.yml
/coverage/
/build/
/phpunit.xml
/var/*
@@ -18,3 +19,4 @@
var/SymfonyRequirements.php
.php_cs.cache
.idea/*
.env
14 .php_cs
@@ -5,8 +5,18 @@ return PhpCsFixer\Config::create()
->setRules([
'@Symfony' => true,
'@Symfony:risky' => true,
'array_syntax' => array('syntax' => 'short'),
'no_extra_consecutive_blank_lines' => array('break', 'continue', 'extra', 'return', 'throw', 'use', 'parenthesis_brace_block', 'square_brace_block', 'curly_brace_block'),
'array_syntax' => ['syntax' => 'short'],
'no_extra_consecutive_blank_lines' => [
'break',
'continue',
'extra',
'return',
'throw',
'use',
'parenthesis_brace_block',
'square_brace_block',
'curly_brace_block'
],
'no_useless_else' => true,
'no_useless_return' => true,
'ordered_class_elements' => true,
@@ -25,7 +25,6 @@ The Home page is now available at "http://localhost:81/".
You need also to create your own GitHub [personal token](https://github.com/settings/tokens) and export it:

```bash
export SYMFONY_PHPUNIT_VERSION=5.7
export GH_TOKEN=XXXXXXXXXXXXXXXXXXXXXXXXXXXX
export GH_SECURED_TOKEN=YYYYYYYYYYYYYYYYYYYYYYYYYYYY
```

0 comments on commit 44f28c8

Please sign in to comment.
You can’t perform that action at this time.