New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2 regarding error 500 when searching products #3

Merged
merged 7 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@Joukz
Contributor

Joukz commented Oct 2, 2018

No description provided.

while (empty($product->link_rewrite[$i])) {
$i++;
}
$link_rewrite = $product->link_rewrite[$i];

This comment has been minimized.

@PierreRambaud

PierreRambaud Oct 3, 2018

Contributor

I don't understand what you are trying to do here? getting the first not empty element in link_rewrite?

This comment has been minimized.

@Joukz

Joukz Nov 9, 2018

Contributor

Yes, exactly. Apparently, the attribute link_rewrite can be an array or a string in some cases. And if it is an array, there are some keys that can be null. So, I need to check it first before using it.

$i++;
}
$link_rewrite = $product->link_rewrite[$i];
}

This comment has been minimized.

@PierreRambaud

PierreRambaud Oct 3, 2018

Contributor

same as previous comment.

This comment has been minimized.

@Joukz

Joukz Nov 9, 2018

Contributor

Code use two times. I have make a function checkLinkrewrite() and make it easier to understand using array_filter.

@marionf

This comment has been minimized.

marionf commented Oct 4, 2018

I still have issue #4

Here the link is ok:

capture d ecran_384

If I click on Copy to clipboard and past it, it's not:

capture d ecran_383

@marionf

This comment has been minimized.

marionf commented Oct 4, 2018

@Joukz
I am logged in FO, I select a product, I select go to cart and click on Copy to clipboard, I am redirected to the home page and my cart is empty

@marionf marionf referenced this pull request Oct 4, 2018

Closed

Links brings to a 404 #4

@marionf marionf added QA ✔️ and removed waiting for author labels Oct 5, 2018

@PierreRambaud PierreRambaud merged commit e8b5241 into PrestaShop:dev Nov 19, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 19, 2018

Thanks @Joukz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment