Simplify logic for picking root category #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hlavtox: I really like your work on dropping cookie usage in the #67 . As for Would you be kind to look at my proposed change, please? Would you agree my logic with |
Previous logic grew into a bit complex one. It had 2 conditional parts each checking for selected BLOCK_CATEG_ROOT_CATEGORY values. They were checking for different setups and later one was conditionally modifying result of the first one. All of that made getWidgetVariables() code a bit hard to follow (understand) and hard to extend (add more scenarios). This change cleans that up. It adds a switch() and handles each BLOCK_CATEG_ROOT_CATEGORY value with a separated code. It should make code easier to understand, debug & develop. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
rmilecki
force-pushed
the
category-choice-cleanup
branch
from
5622dd5
to
90fc817
Compare
0x346e3730
approved these changes
Jan 25, 2023
MhiriFaten
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Hello @rmilecki ,
I have checked every "Category root" available option one by one and they work as expectedin FO. 🎉
So it's QA approved ✔️
Thank you
MhiriFaten
added
QA ✔️
and removed
waiting for QA
|
Thank you @rmilecki ! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCK_CATEG_ROOT_CATEGORYvalues. They were checking for different setups and later one was conditionally modifying result of the first one.All of that made
getWidgetVariables()code a bit hard to follow (understand) and hard to extend (add more scenarios).This change cleans that up. It adds a
switch()and handles eachBLOCK_CATEG_ROOT_CATEGORYvalue with a separated code. It should make code easier to understand, debug & develop.ps_categorytreemodule configuration. Select every "Category root" available option one by one and verify in FO they work as expected. This PR does not modify the behavior, it modifies how the code is written.