Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email display in footer and contact us page configurable #13

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

commented Jul 9, 2019

Questions Answers
Branch? dev
Description? Make the display of email address in footer and contact page's left column configurable.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14416
How to test? see #14416
@PierreRambaud PierreRambaud changed the title feat: remove email from contact us information column Remove email from contact us information column Jul 10, 2019
@colinegin colinegin self-assigned this Jul 16, 2019
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:feat-remove-clear-mail branch 3 times, most recently from 6db3356 to d9813d7 Aug 5, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

hi @LouiseBonnard , this PR has a wording, I ping you here because it doesn't seem like there is a wording label on this repository...

@matthieu-rolland matthieu-rolland changed the base branch from dev to master Aug 5, 2019
@matthieu-rolland matthieu-rolland changed the base branch from master to 1.7.0.x-prev Aug 5, 2019
@matthieu-rolland matthieu-rolland changed the base branch from 1.7.0.x-prev to dev Aug 5, 2019
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:feat-remove-clear-mail branch from d9813d7 to 48f85ae Aug 5, 2019
@matthieu-rolland matthieu-rolland changed the title Remove email from contact us information column Make email display in footer and contact us page configurable Aug 5, 2019
ps_contactinfo.php Outdated Show resolved Hide resolved
ps_contactinfo.php Outdated Show resolved Hide resolved
ps_contactinfo.php Outdated Show resolved Hide resolved
ps_contactinfo.php Outdated Show resolved Hide resolved
ps_contactinfo.php Outdated Show resolved Hide resolved
- add configuration page with switch display/hide form element
- display or not email according to configuration
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:feat-remove-clear-mail branch from 008d548 to d686467 Aug 21, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

I treated your suggestions @PierreRambaud , this pr is ready for re-review. 👍

@sarahdib sarahdib added QA ✔️ and removed Waiting for QA labels Aug 21, 2019
@matthieu-rolland matthieu-rolland merged commit ce7d6f3 into PrestaShop:dev Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.