Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme compatibility indication in configuration page #15

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

commented Aug 22, 2019

The possibility to hide/display the merchant's email address has to be compatible with the current theme. This PR indicates this below the configuration field.

@@ -141,6 +141,7 @@ public function getContent()
'type' => 'switch',
'label' => $this->trans('Display email address', array(), 'Admin.Actions'),
'name' => 'PS_CONTACT_INFO_DISPLAY_EMAIL',
'desc' => $this->trans('Your theme needs to be compatible with this feature', array(), 'Modules.Contactinfo.Admin'),
'values' => array(

This comment has been minimized.

Copy link
@matthieu-rolland

matthieu-rolland Aug 22, 2019

Author Contributor

Hi @LouiseBonnard , I was not so sure of which translation domain to use here ?

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Aug 22, 2019

Will this PR add a configuration page to the 'Contact Information' module? I don't think there is any currently. If yes, you got the right domain. ;-)

This comment has been minimized.

Copy link
@matthieu-rolland

matthieu-rolland Aug 22, 2019

Author Contributor

yes, we added a configuration page in another PR, and this translation will be there, it just hasn't been released yet.

Good then ! thanx

@matks
matks approved these changes Aug 26, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

I'm not sure this needs QA, does it ? 🤔

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

I'm not sure this needs QA, does it ? 🤔

I don't think so either (and I checked the visual with @marionf)

@matthieu-rolland matthieu-rolland merged commit 26f28e2 into PrestaShop:dev Aug 26, 2019
@eternoendless eternoendless changed the title add theme compatibility indication in configuration page Add theme compatibility indication in configuration page Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.