Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the url to avoid doublons #11

Merged
merged 2 commits into from Nov 15, 2019
Merged

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Nov 13, 2019

Rebuild the url with extra parameters instead of concatenating them to avoid doublons

As explained in this issue PrestaShop/PrestaShop#16378

The currency url sometimes had parameters in doublons (only saw it on homepage but maybe in other places as well) this caused a loop in search engine robots
This PR changes the way the url is built so that the extra parameters are now unique

@123monsite-regis

This comment has been minimized.

Copy link

123monsite-regis commented Nov 14, 2019

thanks

i test it on Ps 1.7.6.1 whith ps_currencyselector 2.0.0 .

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 15, 2019
@sarahdib sarahdib self-assigned this Nov 15, 2019
@Progi1984 Progi1984 merged commit 44fc17e into PrestaShop:dev Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.