New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stop execution if mail send failed #14

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
4 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 23, 2019

Catch errors to be sure even if the mail is not working we don't break
the behavior.

@PierreRambaud PierreRambaud changed the base branch from master to dev Jan 23, 2019

Do not stop execution if mail send failed
Catch errors to be sure even if the mail is not working we don't break
the behavior.

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/send-custoimer-alert branch from e72330e to 47e7e01 Jan 23, 2019

@matks

matks approved these changes Jan 24, 2019

@mbadrani mbadrani self-assigned this Jan 28, 2019

@mbadrani mbadrani added QA approved and removed Waiting for QA labels Jan 28, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 28, 2019

@matks matks merged commit fbeda68 into PrestaShop:dev Jan 28, 2019

@Anxote

This comment has been minimized.

Copy link

Anxote commented Feb 4, 2019

Version 2.1.0 worked almost perfect, this version 2.1.1 does not work

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Feb 4, 2019

@Anxote can you tell us more ? what does not work for you ?

@Anxote

This comment has been minimized.

Copy link

Anxote commented Feb 4, 2019

I do not receive any alerts, no stock, no new orders...

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/send-custoimer-alert branch Feb 4, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Feb 4, 2019

Hey, since we add only a try catch and we can't reproduce your issue.
Can you provide us more information?
Do you have some logs?
Is there something displayed here: /admin-dev/configure/advanced/logs/?
Do you have a module which overrides this module?
Kind regards

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Feb 5, 2019

@Anxote are you running php7.2 ?

@Anxote

This comment has been minimized.

Copy link

Anxote commented Feb 5, 2019

@matks Good morning, no, I'm working with php 7.1

@Anxote

This comment has been minimized.

Copy link

Anxote commented Feb 5, 2019

@PierreRambaud no, I do not have any override with this module, but every day an override of this module is generated automatically, and the whole web stops working, except the backoffice, which works correctly, so that the front oficce works again I have to delete said override, the truth I'm a bit lost with everything, I can not find an explanation. Even when the web works correctly, the module does not send the alerts, neither to the clients nor to me.

@Anxote

This comment has been minimized.

Copy link

Anxote commented Feb 9, 2019

This is the file that is generated in the override and everything stops working.

ps_emailalerts.zip

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Feb 11, 2019

Hum, you said you don't have override but you have a generated override every day..
So I conclude, you have an override 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment