Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve remove link #21

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@davidglezz
Copy link

davidglezz commented Oct 9, 2019

  • Use icon instead uppercase X.
  • Add title for accessibility.
- Use icon instead uppercase X.
- Add title for accessibility.
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 10, 2019

Hi @davidglezz ! Thanks for the PR.
Could you please give us a scenario for testing this PR ? :)

@davidglezz

This comment has been minimized.

Copy link
Author

davidglezz commented Oct 11, 2019

I'll try:

  • You have to install the module.
  • Activate the hook displayProductAdditionalInfo.
  • Set a product without stock.
  • With the session initiated as a client, go to the product page and press the module button "notify me when available" or similar text.
  • Go to "my account" click on the mail alerts icon.
  • The previous product appears in the list.
  • The last X of the name is to remove the notification.
  • I have changed the X for an icon and improvements in accessibility.
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 11, 2019

Thanks @davidglezz for the PR and the scenario, it's OK for me :)

@PierreRambaud PierreRambaud merged commit 41b2b2f into PrestaShop:dev Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.